Back

How raise a pull request for new OAuth2 Provider ?

  • 0
  • General
loup
9 Mar, 2024, 22:04

Okay Ive just finish the integration of 42 School as new OAuth2 Provider, how can I make a good pull request (this is my first time contributing to open source project and my first time forking a git project so be indulgeous). Thx !

TL;DR
Developers want to know how to create a pull request for a new OAuth2 provider in the Appwrite project. They have successfully finished their pull request and have created an issue and a new branch. They are unsure where to add screenshots or videos showing their work. The suggestion is to add them to the pull request. It is recommended to open an issue, create another branch for the new feature, and provide clear details along with proof of the feature working. The developer is seeking guidance for their first-time contribution to an open-source project.
D5
9 Mar, 2024, 22:08

Just make it, specify what it does, prove screenshots and videos of it working...

loup
9 Mar, 2024, 22:10

Rn I have only one branch from the fork (main), I guess I have to make another branch no ?

loup
9 Mar, 2024, 22:10
D5
9 Mar, 2024, 22:11

Yes, do it like that. All steps are there

loup
9 Mar, 2024, 22:15

Okay so firstly I have to open an issue

loup
9 Mar, 2024, 22:33

Okay Ive created my issue : https://github.com/appwrite/appwrite/issues/7773 And create my new branch : https://github.com/lxup/appwrite/tree/feat-7773-42-oauth2-provider Now I have to create the pull request but where do I add screen shot or video to show its working (in issue or in pull request) ?

D5
9 Mar, 2024, 22:39

I recommend in the PR

D5
9 Mar, 2024, 22:39

But you can add it in both

D5
9 Mar, 2024, 22:40

Add the link to the PR in the issue and the link to the issue in the PR

loup
9 Mar, 2024, 22:58
Reply

Reply to this thread by joining our Discord

Reply on Discord

Need support?

Join our Discord

Get community support by joining our Discord server.

Join Discord

Get premium support

Join Appwrite Pro and get email support from our team.

Learn more