I realize that this modifier was created to be attached to the view that would be present for a callback listener. But even in the event that this modifier was positioned elsewhere, it should fail silently rather than force unwrap cookies. There could be other deeplinks happening at the same time. Alternatively we should be able to apply this modifier to the root view or even listen to a specific route and roward it accordlingly. Nevertheless, we shouldn't be force unwrapping anything here.
Maybe i'm misunderstanding the logic in the modifier.
public func registerOAuthHandler() -> some View {
onOpenURL { url in
WebAuthComponent.handleIncomingCookie(from: url)
}.onReceive(NotificationCenter.default.publisher(for: notificationType)) { _ in
WebAuthComponent.onCallback()
}
}
I was under the impression that this modifier was required. Are we suppose to be building our own?
i'd think we could modify this to validate the URLComponents before continuing..
public static func handleIncomingCookie(from url: URL) {
guard let components = URLComponents(string: url.absoluteString)!,
validateQueryComponent(components) else {
return
}
let components = URLComponents(string: url.absoluteString)!
let cookieParts = [String: String](uniqueKeysWithValues: components.queryItems!.map {
($0.name, $0.value!)
})
func validateQueryComponents(_ components: URLComponents) -> Bool {
.... to validate
}
that way the app doesn't have to be open to recieve the url, and not crash any other deeplinks i care to listen for elsewhere in the app.
Recommended threads
- Deeplinking/hosting apple-app-site-assoc...
I'm trying to implement deeplinking so that after a user logs in, they are redirected to the place in my app I want them to go. As far as I understand, I need a...
- How to determine if a user is anonymous?
This is probably a silly question, but I have not yet found a good answer. Is there a method to determine if the current session is anonymous aside from seein...
- Do I need to upgrade my Appwrite plan?
So i am making a file hosting & sharing platform (voltzy.lol) and i am expecting approx 5-8 million visit per month and over 30 million uploads per month do i n...