I realize that this modifier was created to be attached to the view that would be present for a callback listener. But even in the event that this modifier was positioned elsewhere, it should fail silently rather than force unwrap cookies. There could be other deeplinks happening at the same time. Alternatively we should be able to apply this modifier to the root view or even listen to a specific route and roward it accordlingly. Nevertheless, we shouldn't be force unwrapping anything here.
Maybe i'm misunderstanding the logic in the modifier.
public func registerOAuthHandler() -> some View {
onOpenURL { url in
WebAuthComponent.handleIncomingCookie(from: url)
}.onReceive(NotificationCenter.default.publisher(for: notificationType)) { _ in
WebAuthComponent.onCallback()
}
}
I was under the impression that this modifier was required. Are we suppose to be building our own?
i'd think we could modify this to validate the URLComponents before continuing..
public static func handleIncomingCookie(from url: URL) {
guard let components = URLComponents(string: url.absoluteString)!,
validateQueryComponent(components) else {
return
}
let components = URLComponents(string: url.absoluteString)!
let cookieParts = [String: String](uniqueKeysWithValues: components.queryItems!.map {
($0.name, $0.value!)
})
func validateQueryComponents(_ components: URLComponents) -> Bool {
.... to validate
}
that way the app doesn't have to be open to recieve the url, and not crash any other deeplinks i care to listen for elsewhere in the app.
Recommended threads
- Quota not resetting
hi, im using appwrite's free tier plani hit my read limts last month and the billing cycle said it would reset on june 4th but that is today, the billing cycle ...
- Realtime Error Invalid query: Syntax err...
I was test driving Self-Hosted Appwrite for my use with Swift IOS apps as a backend while back and after successful trials, I started to move to incorporate int...
- TSL Certificate Issues
Hi Appwrite Discord Community, I got a problem with my Self-Hosted instance. I only want, that I can use my programm with the Appwrite Backend without .selfSig...